Skip to content

fix: Manifest-tag-fix - #331

Open
collinol wants to merge 5 commits into
mainfrom
fix/manifest-tag-fix
Open

fix: Manifest-tag-fix#331
collinol wants to merge 5 commits into
mainfrom
fix/manifest-tag-fix

Conversation

@collinol

@collinol collinol commented Aug 13, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

return error when version not set

Summary by CodeRabbit

  • Bug Fixes
    • Conversions now fail with a clear error when no valid version is available.
    • Version detection supports values from manifests and image tags, with defined precedence.
    • Existing application and image information is preserved during legacy conversions.
    • Manifest lookup is avoided when version validation has already failed.
  • Tests
    • Expanded coverage for missing, empty, and conflicting version values.
    • Added validation for manifest lookup failures and cooldown behavior.

@collinol
collinol marked this pull request as ready for review August 13, 2026 17:26
@collinol
collinol requested a review from a team as a code owner August 13, 2026 17:26
@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f26f22fe-0685-4f17-946e-23bc9a9599e8

📥 Commits

Reviewing files that changed from the base of the PR and between 33d0926 and 22700c7.

📒 Files selected for processing (3)
  • api/v1/weightsandbiases_conversion_overrides.go
  • api/v1/weightsandbiases_conversion_overrides_test.go
  • api/v1/weightsandbiases_conversion_test.go
📝 Walkthrough

Walkthrough

Conversion now derives versions from supported image tags and returns an error when no version exists. Tests cover version precedence, nil and empty values, manifest resolver behavior, fetch ordering, and conversion failures.

Changes

Conversion version validation

Layer / File(s) Summary
Missing-version error handling
api/v1/weightsandbiases_conversion_overrides.go		 mapPerAppLegacyOverrides returns an error when it cannot derive a version from the supported v1 fields.
Version derivation in conversion fixtures
api/v1/weightsandbiases_conversion_test.go		 Fixtures derive versions from app.image.tag before api.image.tag, while dedicated no-version fixtures preserve missing values. Tests cover nil, empty, and absent versions.
Manifest resolution and override conversion tests
api/v1/weightsandbiases_conversion_overrides_test.go		 Tests use shared successful and failing resolvers. They verify validation before fetch, API image-tag conversion, resolver failures, and cooldown behavior.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to 22700

This change adds manifest-version error handling with focused test updates. Routine validation and test-convention follow-up remain, but no actionable merge-blocking correctness or production risk is identified.

Possibly related PRs

  • wandb/operator#319: Both changes modify version derivation and manifest resolution in legacy override conversion.

Suggested reviewers: wnevis-cmyk

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the main change as a fix for manifest tag handling and matches the pull request objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/manifest-tag-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@collinol collinol changed the title fix/manifest-tag-fix fix: Manifest-tag-fix Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@collinol